Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: cc/resources/texture_uploader.cc

Issue 1115653002: Pass gfx structs by const ref(gfx::Vector2D/F) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing some build issue Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/texture_uploader.h ('k') | content/browser/android/overscroll_glow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/texture_uploader.cc
diff --git a/cc/resources/texture_uploader.cc b/cc/resources/texture_uploader.cc
index 601fa8fbff89de41c26075cf1be5d97dff61fdd3..89271bdcb541e3b0643b09b6dd117221a6cb24c7 100644
--- a/cc/resources/texture_uploader.cc
+++ b/cc/resources/texture_uploader.cc
@@ -136,7 +136,7 @@ void TextureUploader::EndQuery() {
void TextureUploader::Upload(const uint8* image,
const gfx::Rect& image_rect,
const gfx::Rect& source_rect,
- gfx::Vector2d dest_offset,
+ const gfx::Vector2d& dest_offset,
ResourceFormat format,
const gfx::Size& size) {
CHECK(image_rect.Contains(source_rect));
@@ -173,7 +173,7 @@ void TextureUploader::ReleaseCachedQueries() {
void TextureUploader::UploadWithTexSubImage(const uint8* image,
const gfx::Rect& image_rect,
const gfx::Rect& source_rect,
- gfx::Vector2d dest_offset,
+ const gfx::Vector2d& dest_offset,
ResourceFormat format) {
TRACE_EVENT0("cc", "TextureUploader::UploadWithTexSubImage");
@@ -227,7 +227,7 @@ void TextureUploader::UploadWithTexSubImage(const uint8* image,
void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
const gfx::Rect& image_rect,
const gfx::Rect& source_rect,
- gfx::Vector2d dest_offset,
+ const gfx::Vector2d& dest_offset,
ResourceFormat format) {
TRACE_EVENT0("cc", "TextureUploader::UploadWithMapTexSubImage");
« no previous file with comments | « cc/resources/texture_uploader.h ('k') | content/browser/android/overscroll_glow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698