chrome/browser/password_manager/password_manager_util_win.cc - Issue 1115583002: [chrome/browser/password_manager] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_util_win.cc

Issue 1115583002: [chrome/browser/password_manager] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_util_win.cc

diff --git a/chrome/browser/password_manager/password_manager_util_win.cc b/chrome/browser/password_manager/password_manager_util_win.cc

index c3ce79de864b0a1ef9f69f9ecb4f98bc65302097..fd8455042ff7d83e87235d369beacdf1f6db74f6 100644

--- a/chrome/browser/password_manager/password_manager_util_win.cc

+++ b/chrome/browser/password_manager/password_manager_util_win.cc

@@ -182,7 +182,7 @@ void ReplyOsPasswordStatus(const base::Callback<void(OsPasswordStatus)>& reply,

void GetOsPasswordStatus(const base::Callback<void(OsPasswordStatus)>& reply) {

// Preferences can be accessed on the UI thread only.

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

PrefService* local_state = g_browser_process->local_state();

PasswordCheckPrefs* prefs = new PasswordCheckPrefs;

prefs->Read(local_state);