chrome/browser/password_manager/password_store_mac.cc - Issue 1115583002: [chrome/browser/password_manager] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 1115583002: [chrome/browser/password_manager] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_util_win.cc ('k') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac.cc

diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc

index f548ff295b518e108dfde8d589f4dc6bed075f88..80a18a721da9a42fd858605acb073e070afe6cc4 100644

--- a/chrome/browser/password_manager/password_store_mac.cc

+++ b/chrome/browser/password_manager/password_store_mac.cc

@@ -922,7 +922,7 @@ PasswordStoreMac::~PasswordStoreMac() {}

bool PasswordStoreMac::Init(

const syncer::SyncableService::StartSyncFlare& flare) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

thread_.reset(new base::Thread("Chrome_PasswordStore_Thread"));

if (!thread_->Start()) {

@@ -944,7 +944,7 @@ void PasswordStoreMac::InitOnBackgroundThread() {

}

void PasswordStoreMac::Shutdown() {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

password_manager::PasswordStore::Shutdown();

thread_->Stop();

}