Issue 1115583002: [chrome/browser/password_manager] favor DCHECK_CURRENTLY_ON for better logs

Issue 1115583002: [chrome/browser/password_manager] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 7 months ago by anujsharma

Modified:
5 years, 7 months ago

Reviewers:
vabr (Chromium), Mike West

CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/password_manager BUG=466848 Committed: https://crrev.com/43a8d2e4003d4188ff0c996d48b2ec0fd867c1ee Cr-Commit-Position: refs/heads/master@{#327483}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -32 lines)			Patch
M	chrome/browser/password_manager/native_backend_gnome_x.cc	View	16 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/password_manager/native_backend_kwallet_x.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/password_manager/password_manager_util_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_store_win.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_store_x.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/29 12:26:45, vabr (Chromium) wrote: > LGTM, Thanks for the improvement! > > Vaclav ...

5 years, 7 months ago (2015-04-29 12:27:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115583002/1

5 years, 7 months ago (2015-04-29 12:27:54 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 13:14:09 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/43a8d2e4003d4188ff0c996d48b2ec0fd867c1ee
Cr-Commit-Position: refs/heads/master@{#327483}