Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: extensions/renderer/safe_builtins.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resource_bundle_source_map.cc ('k') | extensions/renderer/script_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/safe_builtins.cc
diff --git a/extensions/renderer/safe_builtins.cc b/extensions/renderer/safe_builtins.cc
index 707f89d863569c4b44e4b2572562aac18579f533..c3b22df0fc97f4d4e103c991c0d929089b32a745 100644
--- a/extensions/renderer/safe_builtins.cc
+++ b/extensions/renderer/safe_builtins.cc
@@ -135,7 +135,7 @@ void SaveImpl(const char* name,
value);
}
-v8::Local<v8::Object> Load(const char* name, v8::Handle<v8::Context> context) {
+v8::Local<v8::Object> Load(const char* name, v8::Local<v8::Context> context) {
v8::Local<v8::Value> value =
context->Global()->GetHiddenValue(MakeKey(name, context->GetIsolate()));
CHECK(!value.IsEmpty() && value->IsObject()) << name;
@@ -147,15 +147,15 @@ class ExtensionImpl : public v8::Extension {
ExtensionImpl() : v8::Extension(kClassName, kScript) {}
private:
- v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(
+ v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
v8::Isolate* isolate,
- v8::Handle<v8::String> name) override {
+ v8::Local<v8::String> name) override {
if (name->Equals(v8::String::NewFromUtf8(isolate, "Apply")))
return v8::FunctionTemplate::New(isolate, Apply);
if (name->Equals(v8::String::NewFromUtf8(isolate, "Save")))
return v8::FunctionTemplate::New(isolate, Save);
NOTREACHED() << *v8::String::Utf8Value(name);
- return v8::Handle<v8::FunctionTemplate>();
+ return v8::Local<v8::FunctionTemplate>();
}
static void Apply(const v8::FunctionCallbackInfo<v8::Value>& info) {
« no previous file with comments | « extensions/renderer/resource_bundle_source_map.cc ('k') | extensions/renderer/script_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698