Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: extensions/renderer/dom_activity_logger.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/dom_activity_logger.h ('k') | extensions/renderer/event_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/dom_activity_logger.cc
diff --git a/extensions/renderer/dom_activity_logger.cc b/extensions/renderer/dom_activity_logger.cc
index 5cebd389801d2a2bfab5fe563f520c23ede29ce0..53c5917b62d38862b9d2f0068dfbff02ea4ac763 100644
--- a/extensions/renderer/dom_activity_logger.cc
+++ b/extensions/renderer/dom_activity_logger.cc
@@ -23,7 +23,7 @@ namespace {
// Converts the given |v8_value| and appends it to the given |list|, if the
// conversion succeeds.
void AppendV8Value(const std::string& api_name,
- const v8::Handle<v8::Value>& v8_value,
+ const v8::Local<v8::Value>& v8_value,
base::ListValue* list) {
DCHECK(list);
scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
@@ -69,15 +69,15 @@ void DOMActivityLogger::logGetter(const WebString& api_name,
}
void DOMActivityLogger::logSetter(const WebString& api_name,
- const v8::Handle<v8::Value>& new_value,
+ const v8::Local<v8::Value>& new_value,
const WebURL& url,
const WebString& title) {
- logSetter(api_name, new_value, v8::Handle<v8::Value>(), url, title);
+ logSetter(api_name, new_value, v8::Local<v8::Value>(), url, title);
}
void DOMActivityLogger::logSetter(const WebString& api_name,
- const v8::Handle<v8::Value>& new_value,
- const v8::Handle<v8::Value>& old_value,
+ const v8::Local<v8::Value>& new_value,
+ const v8::Local<v8::Value>& old_value,
const WebURL& url,
const WebString& title) {
scoped_ptr<base::ListValue> args(new base::ListValue);
@@ -91,7 +91,7 @@ void DOMActivityLogger::logSetter(const WebString& api_name,
void DOMActivityLogger::logMethod(const WebString& api_name,
int argc,
- const v8::Handle<v8::Value>* argv,
+ const v8::Local<v8::Value>* argv,
const WebURL& url,
const WebString& title) {
scoped_ptr<base::ListValue> args(new base::ListValue);
« no previous file with comments | « extensions/renderer/dom_activity_logger.h ('k') | extensions/renderer/event_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698