Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Issue 1115493002: Merge to XFA: Make CFX_WideString::LockBuffer() completely unused. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Make CFX_WideString::LockBuffer() completely unused. Original Review URL: https://codereview.chromium.org/1053613004 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/134eb282dfaf1e3903979d397db6433966837687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M core/include/fxcrt/fx_string.h View 2 chunks +0 lines, -4 lines 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 2 chunks +13 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-04-28 21:35:32 UTC) #1
Tom Sepez
5 years, 7 months ago (2015-04-28 21:35:45 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as 134eb282dfaf1e3903979d397db6433966837687 (presubmit successful).
5 years, 7 months ago (2015-04-28 21:36:05 UTC) #3
Lei Zhang
5 years, 7 months ago (2015-04-29 00:08:41 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698