Make CFX_WideString::LockBuffer() completely unused.

Make CFX_WideString::LockBuffer() completely unused.

Then remove CFX_{Wide,Byte}String::LockBuffer().  Prelude to a vast
simplification. There's an additional copy now in one place, so
shoot me.

BUG=pdfium:144
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/ee7412f5aef353e5c6f1a64d0e1708ed926869d9

Committed: https://pdfium.googlesource.com/pdfium/+/5a256ad29483eb2b13e6e2c89fe0f77a9103f68f

Committed: https://pdfium.googlesource.com/pdfium/+/4fc0d991a47ba92c1d8657b326d2752951ca791a

[Tom Sepez, 2015-04-24 17:38:04]

Lei, for review.  (Right CL this time).

[Tom Sepez, 2015-04-24 17:38:40]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-04-24 17:38:40]

Actually adding Lei.

Lei, for review (Right CL this time).

[Lei Zhang, 2015-04-27 21:59:04]

lgtm

[Tom Sepez, 2015-04-27 22:00:09]

Committed patchset #1 (id:1) manually as
ee7412f5aef353e5c6f1a64d0e1708ed926869d9 (presubmit successful).

[Tom Sepez, 2015-04-27 22:12:42]

And its reverted ...

[Tom Sepez, 2015-04-27 22:34:18]

Lei, please re-review, with a nod to the lengths I'll go to ...to avoid saying
"delete".

[Lei Zhang, 2015-04-27 22:50:46]

https://codereview.chromium.org/1053613004/diff/20001/core/src/fpdfdoc/doc_bo...
File core/src/fpdfdoc/doc_bookmark.cpp (right):

https://codereview.chromium.org/1053613004/diff/20001/core/src/fpdfdoc/doc_bo...
core/src/fpdfdoc/doc_bookmark.cpp:65: FX_WCHAR* buf = &vec->front();
Can we first check |len| and just return a CFX_WideString() if |len| is 0?
Otherwise, if |len| is 0, the value returned by |vec->front()| is undefined.

[Tom Sepez, 2015-04-28 19:02:20]

Good catch.

https://codereview.chromium.org/1053613004/diff/20001/core/src/fpdfdoc/doc_bo...
File core/src/fpdfdoc/doc_bookmark.cpp (right):

https://codereview.chromium.org/1053613004/diff/20001/core/src/fpdfdoc/doc_bo...
core/src/fpdfdoc/doc_bookmark.cpp:65: FX_WCHAR* buf = &vec->front();
On 2015/04/27 22:50:46, Lei Zhang wrote:
> Can we first check |len| and just return a CFX_WideString() if |len| is 0?
> Otherwise, if |len| is 0, the value returned by |vec->front()| is undefined.

Done.

[Lei Zhang, 2015-04-28 19:14:44]

lgtm

[Tom Sepez, 2015-04-28 19:25:42]

Committed patchset #3 (id:40001) manually as
5a256ad29483eb2b13e6e2c89fe0f77a9103f68f (presubmit successful).

[Tom Sepez, 2015-04-28 19:38:14]

Sheesh ... failed JS tests.

[Tom Sepez, 2015-04-28 21:10:34]

Committed patchset #4 (id:60001) manually as
4fc0d991a47ba92c1d8657b326d2752951ca791a (presubmit successful).