Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1115373002: Remove obsolete NaClBitcodeMunger editing constants. (Closed)

Created:
5 years, 7 months ago by Karl
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove obsolete NaClBitcodeMunger editing constants. These constants are no longer needed. They have been removed from both NaCl and Subzero. Dependent on CL: https://codereview.chromium.org/1120853002 BUG=None R=jvoung@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/d7d2a80eac1d3af93f187560475ff59437d7f23e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Karl
5 years, 7 months ago (2015-04-30 21:49:17 UTC) #2
jvoung (off chromium)
lgtm
5 years, 7 months ago (2015-04-30 22:27:19 UTC) #3
Karl
5 years, 7 months ago (2015-05-05 22:44:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7d2a80eac1d3af93f187560475ff59437d7f23e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698