Issue 1120853002: Fix instruction unit tests to use new editing constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1120853002: Fix instruction unit tests to use new editing constants. (Closed)

Created:
5 years, 7 months ago by Karl

Modified:
5 years, 7 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix instruction unit tests to use new editing constants. Fixes code to follow new editing constants in class NaClMungedBitcode rather than obsolete editing constants in class NaClBitcodeMunger. BUG=None R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0e7e412eed5f508be05dc28c360797bd817e193e

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	unittest/IceParseInstsTest.cpp	View		16 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 4 (1 generated)

Karl

5 years, 7 months ago (2015-04-30 22:32:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0e7e412eed5f508be05dc28c360797bd817e193e (presubmit successful).