Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1115233002: Fix gpu memory accounting for auto-resolving MSAA. (Closed)

Created:
5 years, 7 months ago by Stephen White
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix gpu memory accounting for auto-resolving MSAA. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d298121f5d753b21c62709ae33ac08ddb053c719

Patch Set 1 #

Patch Set 2 : fix it in init() #

Total comments: 1

Patch Set 3 : cache the total computed vram size, not the color values per pixel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/gpu/gl/GrGLRenderTarget.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 1 2 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Stephen White
Brian: PTAL
5 years, 7 months ago (2015-04-30 17:01:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115233002/20001
5 years, 7 months ago (2015-04-30 17:05:37 UTC) #4
bsalomon
https://codereview.chromium.org/1115233002/diff/20001/src/gpu/gl/GrGLRenderTarget.cpp File src/gpu/gl/GrGLRenderTarget.cpp (right): https://codereview.chromium.org/1115233002/diff/20001/src/gpu/gl/GrGLRenderTarget.cpp#newcode48 src/gpu/gl/GrGLRenderTarget.cpp:48: fColorValuesPerPixel = 1; looks ok to me, but can ...
5 years, 7 months ago (2015-04-30 17:34:28 UTC) #5
Stephen White
On 2015/04/30 17:34:28, bsalomon wrote: > https://codereview.chromium.org/1115233002/diff/20001/src/gpu/gl/GrGLRenderTarget.cpp > File src/gpu/gl/GrGLRenderTarget.cpp (right): > > https://codereview.chromium.org/1115233002/diff/20001/src/gpu/gl/GrGLRenderTarget.cpp#newcode48 > ...
5 years, 7 months ago (2015-04-30 17:36:18 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115233002/40001
5 years, 7 months ago (2015-04-30 17:41:45 UTC) #8
Stephen White
New patch up; PTAL. Thanks!
5 years, 7 months ago (2015-04-30 17:45:14 UTC) #9
bsalomon
lgtm
5 years, 7 months ago (2015-04-30 18:45:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115233002/40001
5 years, 7 months ago (2015-04-30 18:53:53 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 19:06:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d298121f5d753b21c62709ae33ac08ddb053c719

Powered by Google App Engine
This is Rietveld 408576698