Issue 11151030: Sleep before moving directory on Windows.

Issue 11151030: Sleep before moving directory on Windows. (Closed)

Created:
8 years, 2 months ago by Bob Nystrom

Modified:
8 years, 2 months ago

Reviewers:
nweiz, dgrove, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Sleep before moving directory on Windows. Gives 7zip more time to finish extracting before we access the directory. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13670

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	utils/pub/hosted_source.dart	View		1 chunk	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://chromiumcodereview.appspot.com/11151030/diff/1/utils/pub/hosted_source.dart File utils/pub/hosted_source.dart (right): https://chromiumcodereview.appspot.com/11151030/diff/1/utils/pub/hosted_source.dart#newcode90 utils/pub/hosted_source.dart:90: // TODO(rnystrom): Awful hack. On Windows, we see cases ...

8 years, 2 months ago (2012-10-16 05:44:04 UTC) #3

dgrove

On 2012/10/16 05:44:04, kasperl wrote: > https://chromiumcodereview.appspot.com/11151030/diff/1/utils/pub/hosted_source.dart > File utils/pub/hosted_source.dart (right): > > https://chromiumcodereview.appspot.com/11151030/diff/1/utils/pub/hosted_source.dart#newcode90 > ...

8 years, 2 months ago (2012-10-16 05:47:50 UTC) #4

kasperl

8 years, 2 months ago (2012-10-16 05:50:18 UTC) #6

On 2012/10/16 05:47:50, dgrove wrote:
> On 2012/10/16 05:44:04, kasperl wrote:
> >
>
https://chromiumcodereview.appspot.com/11151030/diff/1/utils/pub/hosted_sourc...
> > File utils/pub/hosted_source.dart (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/11151030/diff/1/utils/pub/hosted_sourc...
> > utils/pub/hosted_source.dart:90: // TODO(rnystrom): Awful hack. On Windows,
we
> > see cases where the extract
> > This smells like a dart:io bug? Did you file one already?
> 
> issue 5910 was filed for this.

Perfect. Thanks, guys!

Expand Messages | Collapse Messages