Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: utils/pub/hosted_source.dart

Issue 11151030: Sleep before moving directory on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library hosted_source; 5 library hosted_source;
6 6
7 import 'dart:io' as io; 7 import 'dart:io' as io;
8 import 'dart:json'; 8 import 'dart:json';
9 import 'dart:uri'; 9 import 'dart:uri';
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 // Download and extract the archive to a temp directory. 78 // Download and extract the archive to a temp directory.
79 var tempDir; 79 var tempDir;
80 return Futures.wait([httpGet(fullUrl), createTempDir()]).chain((args) { 80 return Futures.wait([httpGet(fullUrl), createTempDir()]).chain((args) {
81 tempDir = args[1]; 81 tempDir = args[1];
82 return timeout(extractTarGz(args[0], tempDir), HTTP_TIMEOUT, 82 return timeout(extractTarGz(args[0], tempDir), HTTP_TIMEOUT,
83 'Timed out while fetching URL "$fullUrl".'); 83 'Timed out while fetching URL "$fullUrl".');
84 }).chain((_) { 84 }).chain((_) {
85 // Now that the install has succeeded, move it to the real location in 85 // Now that the install has succeeded, move it to the real location in
86 // the cache. This ensures that we don't leave half-busted ghost 86 // the cache. This ensures that we don't leave half-busted ghost
87 // directories in the user's pub cache if an install fails. 87 // directories in the user's pub cache if an install fails.
88 return renameDir(tempDir, destPath); 88 var rename = renameDir(tempDir, destPath);
89
90 // TODO(rnystrom): Awful hack. On Windows, we see cases where the extract
kasperl 2012/10/16 05:44:04 This smells like a dart:io bug? Did you file one a
91 // has not finished by the time we get here, so the rename fails with a
92 // "directory in use" error. So, we will just wait a couple of seconds
93 // before we start.
94 if (Platform.operatingSystem == "windows") {
95 rename = sleep(2000).chain((_) => rename);
96 }
97
98 return rename;
89 }).transform((_) => true); 99 }).transform((_) => true);
90 } 100 }
91 101
92 /** 102 /**
93 * The system cache directory for the hosted source contains subdirectories 103 * The system cache directory for the hosted source contains subdirectories
94 * for each separate repository URL that's used on the system. Each of these 104 * for each separate repository URL that's used on the system. Each of these
95 * subdirectories then contains a subdirectory for each package installed 105 * subdirectories then contains a subdirectory for each package installed
96 * from that site. 106 * from that site.
97 */ 107 */
98 String systemCacheDirectory(PackageId id) { 108 String systemCacheDirectory(PackageId id) {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 153
144 var name = description["name"]; 154 var name = description["name"];
145 if (name is! String) { 155 if (name is! String) {
146 throw new FormatException("The 'name' key must have a string value."); 156 throw new FormatException("The 'name' key must have a string value.");
147 } 157 }
148 158
149 var url = description.containsKey("url") ? description["url"] : defaultUrl; 159 var url = description.containsKey("url") ? description["url"] : defaultUrl;
150 return new Pair<String, String>(name, url); 160 return new Pair<String, String>(name, url);
151 } 161 }
152 } 162 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698