Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(539)

Issue 11151005: Improve FastCloneShallowArray/ObjectStubs with VFP copying on ARM (Closed)

Created:
5 years, 2 months ago by Jay Conrod
Modified:
4 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Improve FastCloneShallowArray/ObjectStubs with VFP copying on ARM BUG=none TEST=none

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -19 lines) Patch
M src/arm/assembler-arm.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 3 chunks +47 lines, -19 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +22 lines, -0 lines 1 comment Download
Trybot results:

Messages

Total messages: 6 (0 generated)
danno
http://codereview.chromium.org/11151005/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/11151005/diff/1/src/arm/code-stubs-arm.cc#newcode334 src/arm/code-stubs-arm.cc:334: return CpuFeatures::IsSupported(VFP2) ? 128 : 8; By increasing this ...
5 years, 1 month ago (2012-10-29 15:29:24 UTC) #1
Jay Conrod
Thanks for the comments. This new revision should address everything.
5 years, 1 month ago (2012-10-29 19:47:37 UTC) #2
danno
LGTM with a nit. I'll land this for you when the feature freeze is lifted ...
5 years, 1 month ago (2012-10-30 14:28:59 UTC) #3
m.m.capewell
On Cortex-A9 using svn revision 12837, we see a performance decrease of ~6% on Octane/Box2D ...
5 years, 1 month ago (2012-10-31 13:37:41 UTC) #4
Jay Conrod
I need to borrow a Cortex A9 device from someone here to confirm this. Will ...
5 years, 1 month ago (2012-11-01 00:20:19 UTC) #5
danno
5 years, 1 month ago (2012-11-02 14:12:51 UTC) #6
I have been able to confirm a regression on a nexus prime (A9), although the
regression isn't 100% reproducible. I additionally see a 3.5% regression on
Octane/PDF.js, which does seem reproducible. I'll wait to land this until the
regressions can be addressed.

Powered by Google App Engine
This is Rietveld 0eb02b776