Handle the case where IAttachmentExecute::Save() deletes a downloaded file.

content/browser/download/download_item_impl.h

Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index 432428905f6e7139657c5b51d8943a04260ecdf7..97ea97bf3ead544d1063fda15f102e54f3de432e 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -213,10 +213,10 @@ class CONTENT_EXPORT DownloadItemImpl
     // TODO(rdsmith): Put in state variable for file name determination.
     IN_PROGRESS_INTERNAL,
 
-    // Between commit point (dispatch of download file release) and
-    // completed.  Embedder may be opening the file in this state.
-    // Note that the DownloadItem may be deleted (by shutdown) in this
-    // state.
+    // Between commit point (dispatch of download file release) and completed.
+    // Embedder may be opening the file in this state.  Note that the
+    // DownloadItem may be deleted (by shutdown) or interrupted (e.g. due to a
+    // failure during AnnotateWithSourceInformation()) in this state.
     COMPLETING_INTERNAL,
 
     // After embedder has had a chance to auto-open.  User may now open
@@ -286,7 +286,7 @@ class CONTENT_EXPORT DownloadItemImpl
 
   void ReleaseDownloadFile();
 
-  void OnDownloadFileReleased();
+  void OnDownloadFileReleased(content::DownloadInterruptReason reason);

[Randy Smith (Not in Mondays), 2012/10/27 23:54:28]

After having banged my head against the state machine wall as part of the
download destination refactor, I'm feeling more uncomfortable about this type of
change (which changes the commit point, and allows state transitions to
INTERRUPTED out of the COMPLETING state).  My current perspective is that the
annotation should conceptually be part of the final rename, and release just do
a detach, and I'll be rewriting it that way as part of the DD refactor, but
could you put a TODO here to eliminate the interrupt reason callback and move
the annotation into the final rename?

[asanka, 2012/10/29 15:33:59]

Done.

 
   // Called when the entire download operation (including renaming etc)
   // is completed.