Handle the case where IAttachmentExecute::Save() deletes a downloaded file.

content/browser/download/download_item_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 195 matching lines @@
  private:
   // Fine grained states of a download.
   enum DownloadInternalState {
     // Unless otherwise specified, state transitions are linear forward
     // in this list.
 
     // Includes both before and after file name determination.
     // TODO(rdsmith): Put in state variable for file name determination.
     IN_PROGRESS_INTERNAL,
 
-    // Between commit point (dispatch of download file release) and
-    // completed.  Embedder may be opening the file in this state.
-    // Note that the DownloadItem may be deleted (by shutdown) in this
-    // state.
+    // Between commit point (dispatch of download file release) and completed.
+    // Embedder may be opening the file in this state.  Note that the
+    // DownloadItem may be deleted (by shutdown) or interrupted (e.g. due to a
+    // failure during AnnotateWithSourceInformation()) in this state.
     COMPLETING_INTERNAL,
 
     // After embedder has had a chance to auto-open.  User may now open
     // or auto-open based on extension.
     COMPLETE_INTERNAL,
 
     // User has cancelled the download.
     // Only incoming transition IN_PROGRESS->
     CANCELLED_INTERNAL,
 
@@ skipping 49 matching lines @@
 
   // Called after the delegate has given the go-ahead to actually complete
   // the download.
   void ReadyForDownloadCompletionDone();
 
   void OnDownloadRenamedToFinalName(content::DownloadInterruptReason reason,
                                     const FilePath& full_path);
 
   void ReleaseDownloadFile();
 
-  void OnDownloadFileReleased();
+  void OnDownloadFileReleased(content::DownloadInterruptReason reason);

[Randy Smith (Not in Mondays), 2012/10/27 23:54:28]

After having banged my head against the state machine wall as part of the
download destination refactor, I'm feeling more uncomfortable about this type of
change (which changes the commit point, and allows state transitions to
INTERRUPTED out of the COMPLETING state).  My current perspective is that the
annotation should conceptually be part of the final rename, and release just do
a detach, and I'll be rewriting it that way as part of the DD refactor, but
could you put a TODO here to eliminate the interrupt reason callback and move
the annotation into the final rename?

[asanka, 2012/10/29 15:33:59]

Done.

 
   // Called when the entire download operation (including renaming etc)
   // is completed.
   void Completed();
 
   // Helper routines -----------------------------------------------------------
 
   // Cancel the DownloadFile if we have it.
   void CancelDownloadFile();
 
@@ skipping 184 matching lines @@
 
   // Net log to use for this download.
   const net::BoundNetLog bound_net_log_;
 
   base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_