Issue 1115002: Plumbing for providing a cache thread MessageLoop to the DiskCache backend....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1115002: Plumbing for providing a cache thread MessageLoop to the DiskCache backend.... (Closed)

Created:
10 years, 9 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, michaeln, pam+watch_chromium.org, dpranke+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Plumbing for providing a cache thread MessageLoop to the DiskCache backend. BUG=26730 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42014

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -4 lines)			Patch
M	chrome/browser/appcache/chrome_appcache_service.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/appcache/appcache_thread.h	View	2 chunks	+9 lines, -2 lines	1 comment	Download
M	webkit/appcache/appcache_thread.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_appcache_system.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

10 years, 9 months ago (2010-03-18 22:17:06 UTC) #2

LGTM

http://codereview.chromium.org/1115002/diff/1/3
File webkit/appcache/appcache_thread.h (right):

http://codereview.chromium.org/1115002/diff/1/3#newcode27
webkit/appcache/appcache_thread.h:27: static void Init(int db, int io,
MessageLoop* disk_cache_thread) {
I'm sad for the lack of symmetry but I see that this is the way it has to be.

Expand Messages | Collapse Messages