Chromium Code Reviews
Help | Chromium Project | Sign in
(196)

Issue 1115002: Plumbing for providing a cache thread MessageLoop to the DiskCache backend.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by michaeln
Modified:
3 years, 11 months ago
CC:
chromium-reviews, michaeln, pam+watch_chromium.org, dpranke+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Plumbing for providing a cache thread MessageLoop to the DiskCache backend. BUG=26730 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42014

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/browser/appcache/chrome_appcache_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/appcache/appcache_thread.h View 2 chunks +9 lines, -2 lines 1 comment Download
M webkit/appcache/appcache_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.cc View 1 chunk +2 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
michaeln
Please take a look
5 years, 1 month ago (2010-03-18 21:42:31 UTC) #1
rvargas (out of office)
5 years, 1 month ago (2010-03-18 22:17:06 UTC) #2
LGTM

http://codereview.chromium.org/1115002/diff/1/3
File webkit/appcache/appcache_thread.h (right):

http://codereview.chromium.org/1115002/diff/1/3#newcode27
webkit/appcache/appcache_thread.h:27: static void Init(int db, int io,
MessageLoop* disk_cache_thread) {
I'm sad for the lack of symmetry but I see that this is the way it has to be.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771