Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 11150011: Merge 130848 - Sub-fields in input[type=time] should not be focusable if the input is disabled or r… (Closed)

Created:
8 years, 2 months ago by tkent
Modified:
8 years, 2 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 130848 - Sub-fields in input[type=time] should not be focusable if the input is disabled or read-only https://bugs.webkit.org/show_bug.cgi?id=98850 Reviewed by Kentaro Hara. Source/WebCore: Covered by additional test cases of time-multiple-fields/time-multiple-fields-keyboard-events.html and time-multiple-fields/time-multiple-fields-mouse-events.html. * html/shadow/DateTimeFieldElement.h: (FieldOwner): Add isFieldOwnerDisabledOrReadOnly. * html/shadow/DateTimeFieldElement.cpp: (WebCore::DateTimeFieldElement::isFocusable): Check isFieldOwnerDisabledOrReadOnly, and calls HTMLElement::isFocusable() just in case. * html/shadow/DateTimeEditElement.cpp: (WebCore::DateTimeEditElement::isFieldOwnerDisabledOrReadOnly): Added. * html/shadow/DateTimeEditElement.h: (DateTimeEditElement): Declare isFieldOwnerDisabledOrReadOnly. LayoutTests: * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: * fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: * fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131284

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
tkent
8 years, 2 months ago (2012-10-15 01:20:22 UTC) #1
tkent
8 years, 2 months ago (2012-10-15 01:21:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698