Have jni_generator.gypi specify include_dirs to dependent targets.

Have jni_generator.gypi specify include_dirs to dependent targets.

Rather than each dependent target of a target that generates jni headers having
to specify the appropriate include_dir manually, jni_generator.gypi can do it
via direct_dependent_settings.

TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241216

[blundell, 2013-12-12 12:25:00]

Hi Marcus,

I discovered this in the process of an Autofill refactoring. If you don't
object, I could sweep through and do the removal of the include_dirs of the
targets that depend on jni-header-generating targets.

Thanks,

Colin

[bulach, 2013-12-12 14:38:53]

lgtm

hey colin, I think there was some bizarre targets that wasn't a "direct
dependent settings", but I hope those are the exceptions by now... I'd love if
you could do this across the board, and then add a comment on the ones where
it'd still require the include dir? thanks!

[blundell, 2013-12-16 16:17:45]

Since Marcus is OOO, adding pliard@ and digit@ to take a look over the whole CL
from the Android POV. Note that this CL passed the Android trybots :).

[Philippe, 2013-12-16 16:21:25]

On 2013/12/16 16:17:45, blundell wrote:
> Since Marcus is OOO, adding pliard@ and digit@ to take a look over the whole
CL
> from the Android POV. Note that this CL passed the Android trybots :).

lgtm, thanks Colin for cleaning this up!

[digit1, 2013-12-16 16:25:09]

lgtm - really great cleanup, thanks!

https://codereview.chromium.org/111493006/diff/60001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/111493006/diff/60001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:3159: 'export_dependent_settings': [
Interesting, can you add a comment explaining why this is needed here. I must
say it's a bit surprising to see here.

[blundell, 2013-12-16 16:32:47]

https://codereview.chromium.org/111493006/diff/60001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/111493006/diff/60001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:3159: 'export_dependent_settings': [
I included it because chrome_android_core (in chrome_android.gypi) depends on
this target and I assumed that chrome_android_core included the headers from
chrome_browser_jni_headers (since chrome_android_core had previously declared
the jni gen dir from chrome_browser_jni_headers as an include_dir). Now that I
look at the files in chrome_android_core, however, I don't think that they make
any such inclusions...probably those include_dirs are just unnecessary at this
point. I'll try another build without this export.

On 2013/12/16 16:25:09, digit1 wrote:
> Interesting, can you add a comment explaining why this is needed here. I must
> say it's a bit surprising to see here.

[blundell, 2013-12-16 16:59:35]

Thanks! TBR'ing darin.

[commit-bot: I haz the power, 2013-12-16 17:02:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/111493006/80001

[commit-bot: I haz the power, 2013-12-16 22:26:26]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-12-17 05:59:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/111493006/80001

[commit-bot: I haz the power, 2013-12-17 08:31:36]

Change committed as 241216

[bulach, 2014-01-06 12:15:42]

late lgtm

neat, thanks! :)