content/browser/speech/speech_recognition_manager_impl.h - Issue 11149006: Extend scoped_ptr to be closer to unique_ptr. Support custom deleters, and deleting arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_manager_impl.h

Issue 11149006: Extend scoped_ptr to be closer to unique_ptr. Support custom deleters, and deleting arrays. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix reset() to not call deleter on NULL ptr_. Matches unique_ptr<> spec. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/speech/speech_recognition_manager_impl.h

diff --git a/content/browser/speech/speech_recognition_manager_impl.h b/content/browser/speech/speech_recognition_manager_impl.h

index 732426c49196f6830665a827940eae2f85b30c1f..45480e135c9ef8c2df4c2d479efb67cec1ee8f26 100644

--- a/content/browser/speech/speech_recognition_manager_impl.h

+++ b/content/browser/speech/speech_recognition_manager_impl.h

@@ -90,8 +90,9 @@ class CONTENT_EXPORT SpeechRecognitionManagerImpl :

protected:

// BrowserMainLoop is the only one allowed to istantiate and free us.

+ // Needed for dtor.

Jeffrey Yasskin 2012/11/28 06:07:18 This should be 1 line down.

awong 2012/11/28 10:20:35 Done.

friend class BrowserMainLoop;

- friend class scoped_ptr<SpeechRecognitionManagerImpl>; // Needed for dtor.

+ friend struct base::DefaultDeleter<SpeechRecognitionManagerImpl>;

SpeechRecognitionManagerImpl();

virtual ~SpeechRecognitionManagerImpl();

« base/memory/scoped_ptr.h ('K') | « chrome_frame/chrome_launcher_utils.h ('k') | media/base/audio_bus.h » ('j') | no next file with comments »