Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: lib/compiler/implementation/scanner/class_element_parser.dart

Issue 11148014: Land 'Fix a crash related to obsolete factory syntax.'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/scanner/class_element_parser.dart
diff --git a/lib/compiler/implementation/scanner/class_element_parser.dart b/lib/compiler/implementation/scanner/class_element_parser.dart
index b2a4b031eceba4d9d4c0f58377cae3c63a095482..cd1ae549dec3670bb7a6de90a1cee0b044be7f26 100644
--- a/lib/compiler/implementation/scanner/class_element_parser.dart
+++ b/lib/compiler/implementation/scanner/class_element_parser.dart
@@ -99,6 +99,10 @@ class MemberListener extends NodeListener {
bool isUnary = operator.token.next.next.stringValue === ')';
return Elements.constructOperatorName(operator.source, isUnary);
} else {
+ if (receiver == null) {
+ listener.cancel('library prefix in named factory constructor not '
+ 'implemented', node: send.receiver);
+ }
return Elements.constructConstructorName(receiver.source,
selector.source);
}
« no previous file with comments | « no previous file | lib/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698