Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 11148007: views: Fix a bunch of dchecks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/download/download_item_view.cc
diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc
index d50da195df4f81a0172c08a30ced51ca611a93b6..34696e8d230841619cc7ef031bc194db499ebc33 100644
--- a/chrome/browser/ui/views/download/download_item_view.cc
+++ b/chrome/browser/ui/views/download/download_item_view.cc
@@ -254,7 +254,7 @@ void DownloadItemView::OnExtractIconComplete(IconManager::Handle handle,
// Update the progress graphic on the icon and our text status label
// to reflect our current bytes downloaded, time remaining.
void DownloadItemView::OnDownloadUpdated(DownloadItem* download) {
- DCHECK(download == download_);
+ DCHECK_EQ(download_, download);
if (IsShowingWarningDialog() && !model_->IsDangerous()) {
// We have been approved.
@@ -992,9 +992,9 @@ void DownloadItemView::SetState(State new_body_state, State new_drop_state) {
new_body_state = NORMAL;
// Current body_state_ should always be NORMAL for warning dialogs.
- DCHECK(body_state_ == NORMAL);
+ DCHECK_EQ(NORMAL, body_state_);
// We shouldn't be calling SetState if we are in DANGEROUS_MODE.
- DCHECK(mode_ != DANGEROUS_MODE);
+ DCHECK_NE(DANGEROUS_MODE, mode_);
}
// Avoid extra SchedulePaint()s if the state is going to be the same.
if (body_state_ == new_body_state && drop_down_state_ == new_drop_state)

Powered by Google App Engine
This is Rietveld 408576698