chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc - Issue 11148007: views: Fix a bunch of dchecks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

Issue 11148007: views: Fix a bunch of dchecks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

index f90a19b9278d8baa5ac4ec577ca52efa63e8820a..d7535b230f182988d2fbf39672c6df5ff1b851e4 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

@@ -184,7 +184,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {

}

bool BookmarkContextMenuControllerViews::IsItemChecked(int id) const {

- DCHECK(id == IDC_BOOKMARK_BAR_ALWAYS_SHOW);

+ DCHECK_EQ(IDC_BOOKMARK_BAR_ALWAYS_SHOW, id);

akalin 2012/10/14 09:30:11 please preserve the order of the arguments (e.g.,

tfarina 2012/10/14 22:26:17 No, unless I'm wrong, Peter advocates that it's DC

return profile_->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar);

}