Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 11148007: views: Fix a bunch of dchecks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index 4891f85b49061334c90edd428d823c80afee0618..78cf4dfd7e782075d75c9ea22161070ddd67d4a5 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -124,7 +124,7 @@ views::View* BookmarkBubbleView::GetInitiallyFocusedView() {
void BookmarkBubbleView::WindowClosing() {
// We have to reset |bubble_| here, not in our destructor, because we'll be
// destroyed asynchronously and the shown state will be checked before then.
- DCHECK(bookmark_bubble_ == this);
+ DCHECK_EQ(bookmark_bubble_, this);
bookmark_bubble_ = NULL;
content::NotificationService::current()->Notify(
@@ -277,7 +277,7 @@ void BookmarkBubbleView::ButtonPressed(
}
void BookmarkBubbleView::LinkClicked(views::Link* source, int event_flags) {
- DCHECK(source == remove_link_);
+ DCHECK_EQ(remove_link_, source);
content::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"));
// Set this so we remove the bookmark after the window closes.

Powered by Google App Engine
This is Rietveld 408576698