Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4930)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 11147037: Add a 'hidden' option to chrome.app.window.create() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename 'createHidden' to 'hidden' for less redundancy Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index 97dcd1c195d11743b658a43e703b42493dce3964..4e1417d772939ba6d9c956e75e4798c919f2af0b 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -122,10 +122,14 @@ bool AppWindowCreateFunction::RunImpl() {
create_params.bounds.set_height(maximum_size.height());
if (create_params.bounds.height() < minimum_size.height())
create_params.bounds.set_height(minimum_size.height());
+
+ if (options->hidden.get())
+ create_params.hidden = *options->create_hidden.get();
}
ShellWindow* shell_window =
ShellWindow::Create(profile(), GetExtension(), url, create_params);
- shell_window->GetBaseWindow()->Show();
+ if (!create_params.hidden)
+ shell_window->GetBaseWindow()->Show();
content::WebContents* created_contents = shell_window->web_contents();
int view_id = created_contents->GetRenderViewHost()->GetRoutingID();

Powered by Google App Engine
This is Rietveld 408576698