chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc - Issue 11147037: Add a 'hidden' option to chrome.app.window.create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

Issue 11147037: Add a 'hidden' option to chrome.app.window.create() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rename 'createHidden' to 'hidden' for less redundancy Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h ('k') | chrome/browser/extensions/api/app_window/app_window_api.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

diff --git a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

index 050478f716b7fe4d1138fe17de46a0811078f43b..df0f4dd81be89bfe5aa905307eaf410ef8c64a93 100644

--- a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

+++ b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

@@ -56,4 +56,16 @@ bool AppCurrentWindowInternalRestoreFunction::RunWithWindow(

return true;

}

+bool AppCurrentWindowInternalShowFunction::RunWithWindow(

+ ShellWindow* window) {

+ window->GetBaseWindow()->Show();

+ return true;

+bool AppCurrentWindowInternalHideFunction::RunWithWindow(

+ ShellWindow* window) {

+ window->GetBaseWindow()->Hide();

+ return true;

} // namespace extensions