Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 11147021: [Android] Make AndroidStreamReaderURLRequestJob to start loading asynchronously. (Closed)

Created:
8 years, 2 months ago by mnaganov (inactive)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android] Make AndroidStreamReaderURLRequestJob to start loading asynchronously. This fixes undesired destruction of ResourceLoader inside of StartRequestInternal. R=mkosiba@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161907

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M android_webview/native/android_stream_reader_url_request_job.h View 3 chunks +5 lines, -1 line 3 comments Download
M android_webview/native/android_stream_reader_url_request_job.cc View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mnaganov (inactive)
8 years, 2 months ago (2012-10-15 16:05:37 UTC) #1
mkosiba (inactive)
lgtm
8 years, 2 months ago (2012-10-15 16:08:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/11147021/1
8 years, 2 months ago (2012-10-15 16:13:09 UTC) #3
joth
https://codereview.chromium.org/11147021/diff/1/android_webview/native/android_stream_reader_url_request_job.h File android_webview/native/android_stream_reader_url_request_job.h (right): https://codereview.chromium.org/11147021/diff/1/android_webview/native/android_stream_reader_url_request_job.h#newcode78 android_webview/native/android_stream_reader_url_request_job.h:78: base::WeakPtrFactory<AndroidStreamReaderURLRequestJob> weak_factory_; net::URLRequestJob is refcounted, so it feels like ...
8 years, 2 months ago (2012-10-15 17:01:46 UTC) #4
mnaganov (inactive)
https://codereview.chromium.org/11147021/diff/1/android_webview/native/android_stream_reader_url_request_job.h File android_webview/native/android_stream_reader_url_request_job.h (right): https://codereview.chromium.org/11147021/diff/1/android_webview/native/android_stream_reader_url_request_job.h#newcode78 android_webview/native/android_stream_reader_url_request_job.h:78: base::WeakPtrFactory<AndroidStreamReaderURLRequestJob> weak_factory_; On 2012/10/15 17:01:46, joth wrote: > net::URLRequestJob ...
8 years, 2 months ago (2012-10-15 17:18:25 UTC) #5
mkosiba (inactive)
https://codereview.chromium.org/11147021/diff/1/android_webview/native/android_stream_reader_url_request_job.h File android_webview/native/android_stream_reader_url_request_job.h (right): https://codereview.chromium.org/11147021/diff/1/android_webview/native/android_stream_reader_url_request_job.h#newcode78 android_webview/native/android_stream_reader_url_request_job.h:78: base::WeakPtrFactory<AndroidStreamReaderURLRequestJob> weak_factory_; On 2012/10/15 17:01:46, joth wrote: > net::URLRequestJob ...
8 years, 2 months ago (2012-10-15 17:24:03 UTC) #6
joth
ah OK if this is a standard pattern in URLRequestJobs then lgtm On 15 October ...
8 years, 2 months ago (2012-10-15 18:10:34 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 18:47:33 UTC) #8
Change committed as 161907

Powered by Google App Engine
This is Rietveld 408576698