Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2242)

Unified Diff: android_webview/native/android_stream_reader_url_request_job.cc

Issue 11147021: [Android] Make AndroidStreamReaderURLRequestJob to start loading asynchronously. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/android_stream_reader_url_request_job.cc
diff --git a/android_webview/native/android_stream_reader_url_request_job.cc b/android_webview/native/android_stream_reader_url_request_job.cc
index ee545dfbec257ea499891d779adf574c0364eeca..1abda1ab5c338ff668f54bf00c353f4efbf55807 100644
--- a/android_webview/native/android_stream_reader_url_request_job.cc
+++ b/android_webview/native/android_stream_reader_url_request_job.cc
@@ -6,6 +6,8 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
+#include "base/bind.h"
+#include "base/message_loop.h"
#include "net/base/io_buffer.h"
#include "net/base/mime_util.h"
#include "net/base/net_errors.h"
@@ -47,7 +49,8 @@ AndroidStreamReaderURLRequestJob::AndroidStreamReaderURLRequestJob(
net::NetworkDelegate* network_delegate,
scoped_ptr<Delegate> delegate)
: URLRequestJob(request, network_delegate),
- delegate_(delegate.Pass()) {
+ delegate_(delegate.Pass()),
+ ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
DCHECK(delegate_.get());
}
@@ -55,6 +58,15 @@ AndroidStreamReaderURLRequestJob::~AndroidStreamReaderURLRequestJob() {
}
void AndroidStreamReaderURLRequestJob::Start() {
+ // Start reading asynchronously so that all error reporting and data
+ // callbacks happen as they would for network requests.
+ MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&AndroidStreamReaderURLRequestJob::StartAsync,
+ weak_factory_.GetWeakPtr()));
+}
+
+void AndroidStreamReaderURLRequestJob::StartAsync() {
JNIEnv* env = AttachCurrentThread();
DCHECK(env);

Powered by Google App Engine
This is Rietveld 408576698