Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: chrome/common/extensions/chrome_extensions_client.cc

Issue 1114653002: Suppress all CHECK failures on extension renderer JS exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: duh Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/module_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/chrome_extensions_client.cc
diff --git a/chrome/common/extensions/chrome_extensions_client.cc b/chrome/common/extensions/chrome_extensions_client.cc
index d81d3136de54c66ddfc33308816902b459e70637..d7b295d84a7408eb295b37e6a5f2354629e629fc 100644
--- a/chrome/common/extensions/chrome_extensions_client.cc
+++ b/chrome/common/extensions/chrome_extensions_client.cc
@@ -299,8 +299,10 @@ void ChromeExtensionsClient::RegisterAPISchemaResources(
}
bool ChromeExtensionsClient::ShouldSuppressFatalErrors() const {
- // Suppress fatal on all release branches.
- return GetCurrentChannel() > chrome::VersionInfo::CHANNEL_CANARY;
+ // Suppress fatal everywhere until the cause of bugs like http://crbug/471599
+ // are fixed. This would typically be:
+ // return GetCurrentChannel() > chrome::VersionInfo::CHANNEL_DEV;
+ return true;
}
std::string ChromeExtensionsClient::GetWebstoreBaseURL() const {
« no previous file with comments | « no previous file | extensions/renderer/module_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698