Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 100793006: Show speech button for x-webkit-speech only if the field is editable and focused/hovered. (Closed)

Created:
7 years ago by tkent
Modified:
7 years ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Show speech button for x-webkit-speech only if the field is editable and focused/hovered. BUG=325496 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163981

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-appearance-searchandspeech.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-appearance-speechbutton.html View 3 chunks +13 lines, -2 lines 0 comments Download
M LayoutTests/fast/speech/speech-bidi-rendering.html View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/css/html.css View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
tkent
Hattori-san, would you review this please? This is the last one for crbug.com/325496.
7 years ago (2013-12-13 01:04:14 UTC) #1
keishi
lgtm
7 years ago (2013-12-13 02:06:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/100793006/20001
7 years ago (2013-12-13 02:08:05 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=20502
7 years ago (2013-12-13 03:56:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/100793006/20001
7 years ago (2013-12-13 05:00:15 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=20560
7 years ago (2013-12-13 07:02:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/100793006/20001
7 years ago (2013-12-13 08:52:55 UTC) #7
commit-bot: I haz the power
Change committed as 163860
7 years ago (2013-12-13 11:12:14 UTC) #8
Justin Novosad
A revert of this CL has been created in https://codereview.chromium.org/112643003/ by junov@chromium.org. The reason for ...
7 years ago (2013-12-13 16:45:55 UTC) #9
tkent
A fix for test has been landed. crrev.com/240881 I'll re-land this as is.
7 years ago (2013-12-16 13:54:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/100793006/20001
7 years ago (2013-12-16 13:55:28 UTC) #11
commit-bot: I haz the power
Change committed as 163957
7 years ago (2013-12-16 13:55:59 UTC) #12
tkent
On 2013/12/16 13:55:59, I haz the power (commit-bot) wrote: > Change committed as 163957 This ...
7 years ago (2013-12-16 23:14:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/100793006/20001
7 years ago (2013-12-16 23:15:11 UTC) #14
commit-bot: I haz the power
7 years ago (2013-12-16 23:15:35 UTC) #15
Message was sent while issue was closed.
Change committed as 163981

Powered by Google App Engine
This is Rietveld 408576698