Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 11143018: Use shlex.split() to parse --special-command test argument (Closed)

Created:
8 years, 2 months ago by Reid Kleckner
Modified:
8 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use shlex.split() to parse --special-command test argument This allows passing commands with quoted spaces, such as: tools/test-wrapper-gypbuild.py --special-command \ "$DR/bin64/drrun -ops '-reset_every_nth_pending 0' @" \ ... R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/test.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Reid Kleckner (google)
Hello, I work on Dr. Memory and DynamoRIO, and I'm trying to set up a ...
8 years, 2 months ago (2012-10-15 17:03:09 UTC) #1
Jakob Kummerow
8 years, 2 months ago (2012-10-16 16:19:35 UTC) #2
LGTM. I'll land this for you.

Please note that test.py is about to be replaced by tools/run-tests.py. The
latter is not used on the buildbots yet, but that will most likely change within
the next few weeks. At that point, --special-command will disappear, to be
replaced by --command-prefix and --extra-flags (to specify the stuff before and
after the '@' in --special-command). That should mostly be a drop-in
replacement, but some minor updating of the bot configs might be necessary.

Powered by Google App Engine
This is Rietveld 408576698