tools/test.py - Issue 11143018: Use shlex.split() to parse --special-command test argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/test.py

Issue 11143018: Use shlex.split() to parse --special-command test argument (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/test.py

diff --git a/tools/test.py b/tools/test.py

index 8c62136158e721be7e56d89252314159eb12073f..b3b62b3a636e15a8a8c4d96a41484a8c694f3412 100755

--- a/tools/test.py

+++ b/tools/test.py

@@ -1371,8 +1371,9 @@ def GetSpecialCommandProcessor(value):

else:

pos = value.find('@')

import urllib

- prefix = urllib.unquote(value[:pos]).split()

- suffix = urllib.unquote(value[pos+1:]).split()

+ import shlex

+ prefix = shlex.split(urllib.unquote(value[:pos]))

+ suffix = shlex.split(urllib.unquote(value[pos+1:]))

def ExpandCommand(args):

return prefix + args + suffix

return ExpandCommand

« no previous file with comments | « no previous file | no next file » | no next file with comments »