Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1114043002: Cache experimental natives sources as external strings. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cache experimental natives sources as external strings. R=ulan@chromium.org BUG=v8:4054 LOG=N Committed: https://crrev.com/3ba71e1bbd3b7dc4a81e365be40854e619f29aa0 Cr-Commit-Position: refs/heads/master@{#28176}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : #

Patch Set 4 : also delete experimental native sources at tear down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -26 lines) Patch
M src/api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 3 5 chunks +41 lines, -20 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Yang
5 years, 7 months ago (2015-04-30 11:01:05 UTC) #1
ulan
lgtm
5 years, 7 months ago (2015-04-30 11:03:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114043002/1
5 years, 7 months ago (2015-04-30 11:37:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/2203)
5 years, 7 months ago (2015-04-30 11:47:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114043002/20001
5 years, 7 months ago (2015-04-30 12:27:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/3908)
5 years, 7 months ago (2015-04-30 12:40:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114043002/40001
5 years, 7 months ago (2015-04-30 12:55:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/3917)
5 years, 7 months ago (2015-04-30 13:48:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114043002/60001
5 years, 7 months ago (2015-04-30 13:52:38 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-04-30 15:10:48 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 15:11:09 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3ba71e1bbd3b7dc4a81e365be40854e619f29aa0
Cr-Commit-Position: refs/heads/master@{#28176}

Powered by Google App Engine
This is Rietveld 408576698