src/api.cc - Issue 1114043002: Cache experimental natives sources as external strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1114043002: Cache experimental natives sources as external strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: also delete experimental native sources at tear down Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index c42cab62d55c64735efb722c85f046ab8a2830df..aa5e88729ee059c742ad9c79e08c72c1f38096dc 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -363,7 +363,7 @@ StartupData V8::CreateSnapshotDataBlob(const char* custom_source) {

{

HandleScope scope(isolate);

for (int i = 0; i < i::Natives::GetBuiltinsCount(); i++) {

- internal_isolate->bootstrapper()->NativesSourceLookup(i);

+ internal_isolate->bootstrapper()->SourceLookup<i::Natives>(i);

}

// If we don't do this then we end up with a stray root pointing at the

« no previous file with comments | « no previous file | src/bootstrapper.h » ('j') | no next file with comments »