Issue 11137024: Factoring out of FaviconLoader

Issue 11137024: Factoring out of FaviconLoader (Closed)

Created:
8 years, 2 months ago by groby-ooo-7-16

Modified:
8 years, 2 months ago

Reviewers:
James Hawkins, Greg Billock

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org, rouslan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Factoring out of FaviconLoader TBR=jhawkins@chromium.org R=gbillock@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162195

Patch Set 1 #

Total comments: 7

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -54 lines)			Patch
A	chrome/browser/ui/intents/web_intent_icon_loader.h	View	1 chunk	+49 lines, -0 lines	4 comments	Download
A	chrome/browser/ui/intents/web_intent_icon_loader.cc	View	1 chunk	+49 lines, -0 lines	1 comment	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.h	View	4 chunks	+3 lines, -8 lines	1 comment	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	9 chunks	+9 lines, -36 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.h	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	chrome/browser/ui/intents/web_intent_picker_model.cc	View	1 chunk	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11137024/1

8 years, 2 months ago (2012-10-15 22:17:44 UTC) #3

James Hawkins

8 years, 2 months ago (2012-10-17 03:38:39 UTC) #4

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
File chrome/browser/ui/intents/web_intent_icon_loader.cc (right):

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
chrome/browser/ui/intents/web_intent_icon_loader.cc:30: profile_,
Optional nit: Condense parameters to save rows.

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
File chrome/browser/ui/intents/web_intent_icon_loader.h (right):

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
chrome/browser/ui/intents/web_intent_icon_loader.h:17: class IconLoader {
Document class.

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
chrome/browser/ui/intents/web_intent_icon_loader.h:19: IconLoader(Profile*
profile, WebIntentPickerModel* model);
Document params.

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
chrome/browser/ui/intents/web_intent_icon_loader.h:22: // Load the favicon
associated with |url|.
Loads

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
chrome/browser/ui/intents/web_intent_icon_loader.h:27: void
OnFaviconDataAvailable(
Document what it does.

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
File chrome/browser/ui/intents/web_intent_picker_controller.h (right):

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
chrome/browser/ui/intents/web_intent_picker_controller.h:339: // Object managing
the details of icon loading.
Object that manages the details...

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
File chrome/browser/ui/intents/web_intent_picker_model.h (right):

https://codereview.chromium.org/11137024/diff/1/chrome/browser/ui/intents/web...
chrome/browser/ui/intents/web_intent_picker_model.h:109: // Update favicon for
the intent service with service URL |url| to |image|.
Updates

Expand Messages | Collapse Messages