Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4479)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_model.cc

Issue 11137024: Factoring out of FaviconLoader (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_model.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_model.cc b/chrome/browser/ui/intents/web_intent_picker_model.cc
index 60148278be7d99f1a3a4d8ef5d1583344628437f..16b0fb298af7deac835e8fbb68323dd6adab91d4 100644
--- a/chrome/browser/ui/intents/web_intent_picker_model.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_model.cc
@@ -91,12 +91,18 @@ size_t WebIntentPickerModel::GetInstalledServiceCount() const {
return installed_services_.size();
}
-void WebIntentPickerModel::UpdateFaviconAt(size_t index,
- const gfx::Image& image) {
- DCHECK_LT(index, installed_services_.size());
- installed_services_[index]->favicon = image;
- if (observer_)
- observer_->OnFaviconChanged(this, index);
+void WebIntentPickerModel::UpdateFaviconForServiceWithURL(
+ const GURL& url, const gfx::Image& image) {
+ for (size_t i = 0; i < installed_services_.size(); ++i) {
+ InstalledService* service = installed_services_[i];
+ if (service->url == url) {
+ service->favicon = image;
+ if (observer_)
+ observer_->OnFaviconChanged(this, i);
+ return;
+ }
+ }
+ NOTREACHED(); // Calling this with an invalid URL is not allowed.
}
void WebIntentPickerModel::AddSuggestedExtensions(

Powered by Google App Engine
This is Rietveld 408576698