Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1113653002: Prevent selection handles from showing after a tap (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 7 months ago
Reviewers:
Donn Denman, mohsen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent selection handles from showing after a tap Tap-triggered selections should not trigger the selection handles. If a longpress occurs before a tap-triggered selection, suppress activation of the selection handles. BUG=471280 Committed: https://crrev.com/4938c0c495eb59bc963ebf408ac1d696f0ab3828 Cr-Commit-Position: refs/heads/master@{#327419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ui/touch_selection/touch_selection_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/touch_selection/touch_selection_controller_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
jdduke (slow)
Hey Donn, could you take a look? Sorry it took me so long to get ...
5 years, 7 months ago (2015-04-28 15:56:20 UTC) #2
Donn Denman
lgtm Sorry about the delay!
5 years, 7 months ago (2015-04-28 22:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113653002/1
5 years, 7 months ago (2015-04-28 23:00:45 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-04-28 23:00:47 UTC) #7
jdduke (slow)
+mohsen for review.
5 years, 7 months ago (2015-04-28 23:01:28 UTC) #9
mohsen
On 2015/04/28 23:01:28, jdduke wrote: > +mohsen for review. LGTM
5 years, 7 months ago (2015-04-28 23:33:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113653002/1
5 years, 7 months ago (2015-04-28 23:50:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 02:16:15 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 02:17:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4938c0c495eb59bc963ebf408ac1d696f0ab3828
Cr-Commit-Position: refs/heads/master@{#327419}

Powered by Google App Engine
This is Rietveld 408576698