ui/touch_selection/touch_selection_controller.cc - Issue 1113653002: Prevent selection handles from showing after a tap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/touch_selection/touch_selection_controller.cc

Issue 1113653002: Prevent selection handles from showing after a tap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/touch_selection/touch_selection_controller.cc

diff --git a/ui/touch_selection/touch_selection_controller.cc b/ui/touch_selection/touch_selection_controller.cc

index 3d52b4c3e423f276b65541c1491b0e260411fb86..29068794dbb3af6d1e21b7a28e38b2caa80d3674 100644

--- a/ui/touch_selection/touch_selection_controller.cc

+++ b/ui/touch_selection/touch_selection_controller.cc

@@ -173,6 +173,7 @@ void TouchSelectionController::AllowShowingFromCurrentSelection() {

void TouchSelectionController::OnTapEvent() {

response_pending_input_event_ = TAP;

+ activate_selection_automatically_ = false;

ShowInsertionHandleAutomatically();

if (selection_empty_ && !show_on_tap_for_empty_editable_)

DeactivateInsertion();

« no previous file with comments | « no previous file | ui/touch_selection/touch_selection_controller_unittest.cc » ('j') | no next file with comments »