[android log] add convenience functions and improve tag headspace

[android log] add convenience functions and improve tag headspace

The tag provided to the log functions is now directly used. Getting
the full tag from the group tag should now be done once at class
initialization, which will allow catching long tag errors earlier.

Replaced the "chromium" base tag by "cr"

Added convenience functions to make it easier to call
isLoggable(tag, level)

BUG=472152, 469807
Committed: https://crrev.com/f18fe92b893c9888f1b6cf25806dfddc5b3e1072
Cr-Commit-Position: refs/heads/master@{#327299}

[dgn, 2015-04-28 13:25:41]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2015-04-28 13:25:41]

PTAL, this should fix the problem of "tag too long" errors being discovered too
late.

I would have like to keep the base tag as "chromium" though. But if it's a big
problem, "cr" seems good.

[Bernhard Bauer, 2015-04-28 13:43:58]

lgtm

[dgn, 2015-04-28 13:48:59]

dgn@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-04-28 14:17:56]

lgtm

https://codereview.chromium.org/1113563004/diff/20001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/Log.java (right):

https://codereview.chromium.org/1113563004/diff/20001/base/android/java/src/o...
base/android/java/src/org/chromium/base/Log.java:32: * private static final
String TAG = Log.makeTag("Group");
This change isn't strictly necessary. The IllegalArgumentException works as well
if it's only done at the time of logging. That said, of course you'll catch it
earlier this way.

[dgn, 2015-04-28 14:28:48]

The CQ bit was checked by dgn@chromium.org

[dgn, 2015-04-28 14:28:48]

Thanks for the quick review!

https://codereview.chromium.org/1113563004/diff/20001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/Log.java (right):

https://codereview.chromium.org/1113563004/diff/20001/base/android/java/src/o...
base/android/java/src/org/chromium/base/Log.java:32: * private static final
String TAG = Log.makeTag("Group");
On 2015/04/28 14:17:56, Yaron wrote:
> This change isn't strictly necessary. The IllegalArgumentException works as
well
> if it's only done at the time of logging. That said, of course you'll catch it
> earlier this way.

Yes, I initially assumed it would be enough. But people started seeing such
errors on trunk so... Also, for error logs for example, they are not reached
often. It would be sad to get a logging exception/crash instead of logging the
actual error.

[commit-bot: I haz the power, 2015-04-28 14:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113563004/20001

[commit-bot: I haz the power, 2015-04-28 16:20:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-28 16:21:28]

Patchset 2 (id:??) landed as
https://crrev.com/f18fe92b893c9888f1b6cf25806dfddc5b3e1072
Cr-Commit-Position: refs/heads/master@{#327299}