Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: base/android/junit/src/org/chromium/base/LogTest.java

Issue 1113563004: [android log] add convenience functions and improve tag headspace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/junit/src/org/chromium/base/LogTest.java
diff --git a/base/android/junit/src/org/chromium/base/LogTest.java b/base/android/junit/src/org/chromium/base/LogTest.java
index 14726fe254a00ca1e8b52264d8cf260223083776..46bdc67e62dcf970b8b03f97ffb25a90491257ac 100644
--- a/base/android/junit/src/org/chromium/base/LogTest.java
+++ b/base/android/junit/src/org/chromium/base/LogTest.java
@@ -25,9 +25,15 @@
/** Test method for {@link Log#makeTag(String)} */
@Test
public void testMakeTag() {
- assertEquals("chromium.Foo", Log.makeTag("Foo"));
- assertEquals("chromium", Log.makeTag(null));
- assertEquals("chromium", Log.makeTag(""));
+ assertEquals("cr.Foo", Log.makeTag("Foo"));
+ assertEquals("cr", Log.makeTag(null));
+ assertEquals("cr", Log.makeTag(""));
+ }
+
+ /** Test method for {@link Log#makeTag(String)} */
+ @Test(expected = IllegalArgumentException.class)
+ public void testMakeTagFailure() {
+ Log.makeTag("ThisIs21Char.....Long");
}
/** Tests that the computed call origin is the correct one. */

Powered by Google App Engine
This is Rietveld 408576698