Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
111333003:
android: Add download URL for API 19 x86 system images. (Closed)
|
Created:
7 years ago by digit1 Modified:
7 years ago CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Descriptionandroid: Add download URL for API 19 x86 system images.
Otherwise, running build/android/install_emulator_deps.py fails with
... [python stack trace] ...
Exception: ERROR: no URL known for x86 image for android-19
BUG=NONE
R=yfriedman@chromium.org,navabi@chromium.org,raphael.kubo.da.costa@chromium.org,mariakhomenko@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241258
Patch Set 1 #
Total comments: 4
Messages
Total messages: 12 (0 generated)
This fixes the download issue for me. https://codereview.chromium.org/111333003/diff/1/build/android/install_emulat... File build/android/install_emulator_deps.py (right): https://codereview.chromium.org/111333003/diff/1/build/android/install_emulat... build/android/install_emulator_deps.py:142: rc = cmd_helper.RunCmd(['kvm-ok']) This may need to have 'sudo' as well. See: Traceback (most recent call last): File "./build/android/install_emulator_deps.py", line 263, in <module> sys.exit(main(sys.argv)) File "./build/android/install_emulator_deps.py", line 259, in main InstallKVM() File "./build/android/install_emulator_deps.py", line 142, in InstallKVM rc = cmd_helper.RunCmd(['kvm-ok']) File "/home/tfarina/chromium/src/build/android/pylib/cmd_helper.py", line 43, in RunCmd return Call(args, cwd=cwd) File "/home/tfarina/chromium/src/build/android/pylib/cmd_helper.py", line 25, in Call env=env) File "/home/tfarina/chromium/src/build/android/pylib/cmd_helper.py", line 20, in Popen preexec_fn=lambda: signal.signal(signal.SIGPIPE, signal.SIG_DFL)) File "/usr/lib/python2.7/subprocess.py", line 679, in __init__ errread, errwrite) File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory
https://codereview.chromium.org/111333003/diff/1/build/android/install_emulat... File build/android/install_emulator_deps.py (right): https://codereview.chromium.org/111333003/diff/1/build/android/install_emulat... build/android/install_emulator_deps.py:142: rc = cmd_helper.RunCmd(['kvm-ok']) Hmmm, I don't have an issue running 'kvm-ok' without sudo. I'm on Ubuntu 12.04, what is your system exactly?
https://codereview.chromium.org/111333003/diff/1/build/android/install_emulat... File build/android/install_emulator_deps.py (right): https://codereview.chromium.org/111333003/diff/1/build/android/install_emulat... build/android/install_emulator_deps.py:142: rc = cmd_helper.RunCmd(['kvm-ok']) On 2013/12/16 12:28:04, digit1 wrote: > Hmmm, I don't have an issue running 'kvm-ok' without sudo. I'm on Ubuntu 12.04, > what is your system exactly? I'm also on Ubuntu 12.04 x64, my Window Manager is i3.
Fixed Raphael's email (intel.com, not chromium.org :-)) https://chromiumcodereview.appspot.com/111333003/diff/1/build/android/install... File build/android/install_emulator_deps.py (right): https://chromiumcodereview.appspot.com/111333003/diff/1/build/android/install... build/android/install_emulator_deps.py:142: rc = cmd_helper.RunCmd(['kvm-ok']) Looking at the kvm-ok sources, it looks like it can require root (if /dev/kvm doesn't exist). I'll address that in a different patch. I'm not sure this would explain the "No such file or directory" error though. Thiago, can you tell me the following: 1) The output of: grep -e "^flags" /proc/cpuinfo | sort -u 2) If /dev/kvm and /dev/cpu/0/msr exist in your system 3) Install path of kvm-ok (mine is /usr/sbin/kvm-ok). Thanks.
lgtm
lgtm
lgtm
On 2013/12/16 17:27:00, digit1 wrote: > https://chromiumcodereview.appspot.com/111333003/diff/1/build/android/install... > build/android/install_emulator_deps.py:142: rc = cmd_helper.RunCmd(['kvm-ok']) > Looking at the kvm-ok sources, it looks like it can require root (if /dev/kvm > doesn't exist). I'll address that in a different patch. I'm not sure this would > explain the "No such file or directory" error though. > > Thiago, can you tell me the following: > > 1) The output of: grep -e "^flags" /proc/cpuinfo | sort -u > 2) If /dev/kvm and /dev/cpu/0/msr exist in your system > 3) Install path of kvm-ok (mine is /usr/sbin/kvm-ok). > Follow the requested information: 1) flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm sse4_1 sse4_2 popcnt lahf_lm arat dtherm tpr_shadow vnmi flexpriority ept vpid 2) They don't exist. 3) $ kvm-ok Command 'kvm-ok' is available in '/usr/sbin/kvm-ok' The command could not be located because '/usr/sbin' is not included in the PATH environment variable. This is most likely caused by the lack of administrative privileges associated with your user account. kvm-ok: command not found
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/111333003/1
On 2013/12/16 20:38:22, tfarina wrote: > 3) > $ kvm-ok > Command 'kvm-ok' is available in '/usr/sbin/kvm-ok' > The command could not be located because '/usr/sbin' is not included in the PATH > environment variable. > This is most likely caused by the lack of administrative privileges associated > with your user account. > kvm-ok: command not found Looks like this is the real reason. Strange that /usr/sbin is part of my default $PATH, but this definitely means sudo should always be used when invoking it, I'll update the other patch, thank for the data!
Message was sent while issue was closed.
Change committed as 241258 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
