android: Add download URL for API 19 x86 system images.

build/android/install_emulator_deps.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Installs deps for using SDK emulator for testing.
 
 The script will download the SDK and system images, if they are not present, and
 install and enable KVM, if virtualization has been enabled in the BIOS.
 """
@@ skipping 20 matching lines @@
 SDK_ZIP = 'adt-bundle-linux-x86_64-20131030.zip'
 
 # Android x86 system image from the Intel website:
 # http://software.intel.com/en-us/articles/intel-eula-x86-android-4-2-jelly-bean-bin
 # These don't exist prior to Android-15.
 # As of 08 Nov 2013, Android-19 is not yet available either.
 X86_IMG_URLS = {
   15: 'http://download-software.intel.com/sites/landingpage/android/sysimg_x86-15_r01.zip',
   16: 'http://download-software.intel.com/sites/landingpage/android/sysimg_x86-16_r01.zip',
   17: 'http://download-software.intel.com/sites/landingpage/android/sysimg_x86-17_r01.zip',
-  18: 'http://download-software.intel.com/sites/landingpage/android/sysimg_x86-18_r01.zip'}
+  18: 'http://download-software.intel.com/sites/landingpage/android/sysimg_x86-18_r01.zip',
+  19: 'http://download-software.intel.com/sites/landingpage/android/sysimg_x86-19_r01.zip'}
 
 def CheckSDK():
   """Check if SDK is already installed.
 
   Returns:
     True if the emulator SDK directory (src/android_emulator_sdk/) exists.
   """
   return os.path.exists(constants.EMULATOR_SDK_ROOT)
 
 
@@ skipping 79 matching lines @@
   if rc:
     logging.critical('ERROR: Did not install KVM. Make sure hardware '
                      'virtualization is enabled in BIOS (i.e. Intel VT-x or '
                      'AMD SVM).')
   # TODO(navabi): Use modprobe kvm-amd on AMD processors.
   rc = cmd_helper.RunCmd(['sudo', 'modprobe', 'kvm-intel'])
   if rc:
     logging.critical('ERROR: Did not add KVM module to Linux Kernal. Make sure '
                      'hardware virtualization is enabled in BIOS.')
   # Now check to ensure KVM acceleration can be used.
   rc = cmd_helper.RunCmd(['kvm-ok'])

[tfarina, 2013/12/16 12:07:11]

This may need to have 'sudo' as well.

See:

Traceback (most recent call last):
  File "./build/android/install_emulator_deps.py", line 263, in <module>
    sys.exit(main(sys.argv))
  File "./build/android/install_emulator_deps.py", line 259, in main
    InstallKVM()
  File "./build/android/install_emulator_deps.py", line 142, in InstallKVM
    rc = cmd_helper.RunCmd(['kvm-ok'])
  File "/home/tfarina/chromium/src/build/android/pylib/cmd_helper.py", line 43,
in RunCmd
    return Call(args, cwd=cwd)
  File "/home/tfarina/chromium/src/build/android/pylib/cmd_helper.py", line 25,
in Call
    env=env)
  File "/home/tfarina/chromium/src/build/android/pylib/cmd_helper.py", line 20,
in Popen
    preexec_fn=lambda: signal.signal(signal.SIGPIPE, signal.SIG_DFL))
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

[digit1, 2013/12/16 12:28:04]

Hmmm, I don't have an issue running 'kvm-ok' without sudo. I'm on Ubuntu 12.04,
what is your system exactly?

[tfarina, 2013/12/16 12:29:52]

I'm also on Ubuntu 12.04 x64, my Window Manager is i3.

[digit1, 2013/12/16 17:27:00]

Looking at the kvm-ok sources, it looks like it can require root (if /dev/kvm
doesn't exist). I'll address that in a different patch. I'm not sure this would
explain the "No such file or directory" error though.

Thiago, can you tell me the following:

1) The output of: grep -e "^flags" /proc/cpuinfo | sort -u
2) If /dev/kvm and /dev/cpu/0/msr exist in your system
3) Install path of kvm-ok (mine is /usr/sbin/kvm-ok).

Thanks.

   if rc:
     logging.critical('ERROR: Can not use KVM acceleration. Make sure hardware '
                      'virtualization is enabled in BIOS (i.e. Intel VT-x or '
                      'AMD SVM).')
 
 
 def GetX86Image(api_level=DEFAULT_ANDROID_API_LEVEL):
   """Download x86 system image from Intel's website.
 
   Args:
@@ skipping 101 matching lines @@
 
   # Make sure KVM packages are installed and enabled.
   if CheckKVM():
     logging.info('KVM already installed and enabled.')
   else:
     InstallKVM()
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))