Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1113313003: Create GrCommandBuilder (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 2

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -243 lines) Patch
M gyp/gpu.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/GrCommandBuilder.h View 1 chunk +85 lines, -0 lines 0 comments Download
A src/gpu/GrCommandBuilder.cpp View 1 chunk +197 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 10 chunks +20 lines, -18 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 3 chunks +5 lines, -39 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 chunks +0 lines, -184 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
Mostly just moving code around to create GrCommandBuilder. ptal
5 years, 7 months ago (2015-05-04 18:26:31 UTC) #2
bsalomon
lgtm but is there any way we can layer these classes better so we need ...
5 years, 7 months ago (2015-05-05 15:07:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113313003/40001
5 years, 7 months ago (2015-05-05 15:29:59 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 15:41:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e46760e8b2b2fc4a11a43a3b7cc9da7166c83c46

Powered by Google App Engine
This is Rietveld 408576698