Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 111323005: Remvoe duplicate impl for SkImageInfo flattening (Closed)

Created:
7 years ago by reed1
Modified:
7 years ago
Reviewers:
hal.canary, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remvoe duplicate impl for SkImageInfo flattening Add onNewLockPixels This reverts commit bb8eff6a70c52b7644391cfd4f4d21bf7294a6bf. BUG= Committed: https://code.google.com/p/skia/source/detail?r=12665

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -316 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkMallocPixelRef.h View 1 chunk +35 lines, -16 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkPixelRef.h View 1 4 chunks +58 lines, -21 lines 0 comments Download
M include/gpu/GrSurface.h View 2 chunks +3 lines, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 2 chunks +4 lines, -6 lines 0 comments Download
M include/images/SkImageRef.h View 3 chunks +3 lines, -4 lines 0 comments Download
M include/images/SkImageRef_GlobalPool.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePicture.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 2 chunks +21 lines, -9 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +17 lines, -18 lines 0 comments Download
M src/core/SkImageFilterUtils.cpp View 2 chunks +13 lines, -3 lines 0 comments Download
M src/core/SkMallocPixelRef.cpp View 3 chunks +111 lines, -20 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 2 6 chunks +56 lines, -37 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +20 lines, -8 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 3 chunks +25 lines, -26 lines 0 comments Download
M src/image/SkDataPixelRef.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/image/SkDataPixelRef.cpp View 2 chunks +18 lines, -7 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +3 lines, -13 lines 0 comments Download
M src/images/SkImageRef.cpp View 7 chunks +11 lines, -20 lines 0 comments Download
M src/images/SkImageRef_GlobalPool.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/images/SkImageRef_ashmem.h View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageRef_ashmem.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/lazy/SkCachingPixelRef.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 1 5 chunks +19 lines, -15 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 1 2 3 chunks +22 lines, -14 lines 0 comments Download
M tests/PictureTest.cpp View 1 3 chunks +3 lines, -32 lines 0 comments Download
M tests/PixelRefTest.cpp View 1 chunk +13 lines, -11 lines 0 comments Download
M tests/SerializationTest.cpp View 1 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
7 years ago (2013-12-13 14:13:02 UTC) #1
reed1
Committed patchset #3 manually as r12665 (presubmit successful).
7 years ago (2013-12-13 14:18:30 UTC) #2
hal.canary
7 years ago (2013-12-13 14:19:13 UTC) #3
Message was sent while issue was closed. 
On 2013/12/13 14:18:30, reed1 wrote:
> Committed patchset #3 manually as r12665 (presubmit successful).

lgtm, as long as all tests pass

Powered by Google App Engine
This is Rietveld 408576698