CSSStyleDeclaration.cssFloat is not enumerated property

Source/core/css/CSSComputedStyleDeclaration.cpp

Index: Source/core/css/CSSComputedStyleDeclaration.cpp
diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp
index df84903ef27a30ab300efc8405dd9e60968ed193..3cf16f9b3e4d0cfb37e99f22fc98fea1299b3e42 100644
--- a/Source/core/css/CSSComputedStyleDeclaration.cpp
+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp
@@ -403,6 +403,15 @@ void CSSComputedStyleDeclaration::setCSSText(const String&, ExceptionState& exce
     exceptionState.throwDOMException(NoModificationAllowedError, "These styles are computed, and therefore read-only.");
 }
 
+String CSSComputedStyleDeclaration::cssFloat() const
+{
+    return "";

[Timothy Loh, 2015/06/24 00:35:00]

These are wrong, the spec defines cssFloat in terms of getPropertyValue and
setProperty, so this should probably return an actual value and setCSSFloat
should probably raise an exception. Maybe we can make the base class implement
these to call the virtual functions instead?

http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-cssfloat

[Sunil Ratnu, 2015/06/24 13:17:11]

Using getPropertyValue(CSSPropertyFloat) in the cssFloat() method now.

Also to throw the exception, we will need to use [RaisesException=Setter] in the
idl. The spec says that "Any exceptions thrown must be re-thrown", could you
please let me know what kind of exception type are we supposed to throw here?

In the base class almost all the methods have been kept as pure virtual and have
their definitions in the derived classes, so it seems better to follow the same
here as well.

On 2015/06/24 00:35:00, Timothy Loh wrote:

+}
+
+void CSSComputedStyleDeclaration::setCSSFloat(const String& value)
+{
+}
+
 static CSSValueID cssIdentifierForFontSizeKeyword(int keywordSize)
 {
     ASSERT_ARG(keywordSize, keywordSize);