CSSStyleDeclaration.cssFloat is not enumerated property

Source/core/css/CSSComputedStyleDeclaration.cpp

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2011 Sencha, Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
@@ skipping 385 matching lines @@
     }
 
     return result.toString();
 }
 
 void CSSComputedStyleDeclaration::setCSSText(const String&, ExceptionState& exceptionState)
 {
     exceptionState.throwDOMException(NoModificationAllowedError, "These styles are computed, and therefore read-only.");
 }
 
+String CSSComputedStyleDeclaration::cssFloat() const
+{
+    return "";

[Timothy Loh, 2015/06/24 00:35:00]

These are wrong, the spec defines cssFloat in terms of getPropertyValue and
setProperty, so this should probably return an actual value and setCSSFloat
should probably raise an exception. Maybe we can make the base class implement
these to call the virtual functions instead?

http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-cssfloat

[Sunil Ratnu, 2015/06/24 13:17:11]

Using getPropertyValue(CSSPropertyFloat) in the cssFloat() method now.

Also to throw the exception, we will need to use [RaisesException=Setter] in the
idl. The spec says that "Any exceptions thrown must be re-thrown", could you
please let me know what kind of exception type are we supposed to throw here?

In the base class almost all the methods have been kept as pure virtual and have
their definitions in the derived classes, so it seems better to follow the same
here as well.

On 2015/06/24 00:35:00, Timothy Loh wrote:

+}
+
+void CSSComputedStyleDeclaration::setCSSFloat(const String& value)
+{
+}
+
 static CSSValueID cssIdentifierForFontSizeKeyword(int keywordSize)
 {
     ASSERT_ARG(keywordSize, keywordSize);
     ASSERT_ARG(keywordSize, keywordSize <= 8);
     return static_cast<CSSValueID>(CSSValueXxSmall + keywordSize - 1);
 }
 
 inline static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> zoomAdjustedPixelValue(double value, const ComputedStyle& style)
 {
     return cssValuePool().createValue(adjustFloatForAbsoluteZoom(value, style), CSSPrimitiveValue::CSS_PX);
@@ skipping 276 matching lines @@
     exceptionState.throwDOMException(NoModificationAllowedError, "These styles are computed, and therefore the '" + getPropertyNameString(id) + "' property is read-only.");
 }
 
 DEFINE_TRACE(CSSComputedStyleDeclaration)
 {
     visitor->trace(m_node);
     CSSStyleDeclaration::trace(visitor);
 }
 
 } // namespace blink