Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: Tools/Scripts/check-testharness-expected-pass

Issue 1112973002: Allow expected.txt files in testharness LayoutTests w/console warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test fix and dpranke nit Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/check-testharness-expected-pass
diff --git a/Tools/Scripts/check-testharness-expected-pass b/Tools/Scripts/check-testharness-expected-pass
index 519132d6ca0a735f082a88b2f32e649ff3f0b01c..7ed48f7947b700c48e79795abda8e40a1e76d4f6 100755
--- a/Tools/Scripts/check-testharness-expected-pass
+++ b/Tools/Scripts/check-testharness-expected-pass
@@ -21,9 +21,9 @@ paths = []
for path in sys.argv[1:]:
content = open(path, 'r').read()
- if testharness_results.is_testharness_output(content) and \
- testharness_results.is_testharness_output_passing(content) and \
- not testharness_results.is_testharness_output_with_console_errors(content):
+ if (testharness_results.is_testharness_output(content) and
+ testharness_results.is_testharness_output_passing(content) and
+ not testharness_results.is_testharness_output_with_console_errors_or_warnings(content)):
paths.append(path)
if len(paths) > 0:
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698