Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 111293002: Add ui back as a dependency of media_perftests. This fixes an Android failure. (Closed)

Created:
7 years ago by rileya (GONE FROM CHROMIUM)
Modified:
7 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add ui back as a dependency of media_perftests. This fixes an Android failure. This reverts part of: https://codereview.chromium.org/83243007 BUG=327205, 302505 TBR=tfarina Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rileya (GONE FROM CHROMIUM)
The hidden dependency that caused media_unitests to fail on the trybots for https://codereview.chromium.org/83243007 also exists ...
7 years ago (2013-12-10 04:13:10 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-10 04:13:51 UTC) #2
rileya (GONE FROM CHROMIUM)
Andrew: mind having a look?
7 years ago (2013-12-10 04:18:26 UTC) #3
scherkus (not reviewing)
lgtm
7 years ago (2013-12-10 18:27:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/111293002/1
7 years ago (2013-12-10 18:28:02 UTC) #5
tfarina
nasty! but OK. sorry for the android breakage. Thanks for the fix! informal lgtm.
7 years ago (2013-12-10 21:00:43 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-10 21:32:23 UTC) #7
Message was sent while issue was closed.
Change committed as 239849

Powered by Google App Engine
This is Rietveld 408576698