Issue 83243007: Remove unnecessary dependencies on 'ui' target from media targets.

Issue 83243007: Remove unnecessary dependencies on 'ui' target from media targets. (Closed)

Created:
7 years, 1 month ago by tfarina

Modified:
7 years ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove 'ui' dependency from some media targets where it isn't necessary. This targets from where ui dependency is being removed do not include anything from ui/base, so they don't to list ui as its dependency. media_unittests was left over because it was blocked by some hidden dependency that was triggered by the android build. BUG=302505 TEST=media_perftests, player_x11 R=fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239184

Patch Set 1 #

Patch Set 2 : gl dep #

Patch Set 3 : add back ui.gyp #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	media/media.gyp	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 20 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

lgtm assuming trybots are happy. To unsubscribe from this group and stop receiving emails from ...

7 years, 1 month ago (2013-11-23 16:44:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/83243007/1

7 years, 1 month ago (2013-11-23 16:47:30 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=194402

7 years, 1 month ago (2013-11-23 18:31:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/83243007/1

7 years, 1 month ago (2013-11-23 18:35:46 UTC) #5

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test on builder ...

7 years ago (2013-11-24 00:39:49 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/83243007/1

7 years ago (2013-11-24 01:17:08 UTC) #7

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test on builder ...

7 years ago (2013-11-24 06:49:05 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/83243007/1

7 years ago (2013-11-24 17:38:42 UTC) #9

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test on builder ...

7 years ago (2013-11-24 23:00:29 UTC) #10

tfarina

Ami, the android failure seems real, but I don't understand its output: http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/105957/steps/media_unittests/logs/stdio

7 years ago (2013-11-24 23:09:11 UTC) #11

tfarina

7 years ago (2013-11-24 23:09:11 UTC) #12

Ami GONE FROM CHROMIUM

On Sun, Nov 24, 2013 at 3:09 PM, <tfarina@chromium.org> wrote: > > Ami, the android ...

7 years ago (2013-11-25 18:52:33 UTC) #13

On Sun, Nov 24, 2013 at 3:09 PM, <tfarina@chromium.org> wrote:
>
> Ami, the android failure seems real, but I don't understand its output:
> http://build.chromium.org/p/tryserver.chromium/builders/
> android_dbg_triggered_tests/builds/105957/steps/media_unittests/logs/stdio


It is unfortunate (but apparently a known and low priority issue) that the
output from logcat, which is essential to understanding many failures, is
not linked from each step that might fail, but only from the slave_steps
uberstep.  In this case you're looking for:
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...

and the relevant log snippet seems to be:

1D018:  11-24 22:33:10.179  4850  4850 W System.err:
java.lang.NoClassDefFoundError:
org/chromium/ui/gl/SurfaceTexturePlatformWrapper
1D018:  11-24 22:33:10.179  4850  4850 W System.err:    at
org.chromium.native_test.ChromeNativeTestActivity.nativeRunTests(Native
Method)
1D018:  11-24 22:33:10.179  4850  4850 W System.err:    at
org.chromium.native_test.ChromeNativeTestActivity.runTests(ChromeNativeTestActivity.java:60)
1D018:  11-24 22:33:10.179  4850  4850 W System.err:    at
org.chromium.native_test.ChromeNativeTestActivity.access$000(ChromeNativeTestActivity.java:21)
1D018:  11-24 22:33:10.179  4850  4850 W System.err:    at
org.chromium.native_test.ChromeNativeTestActivity$2.run(ChromeNativeTestActivity.java:52)
1D018:  11-24 22:33:10.179  4850  4850 W System.err:    at
android.os.Handler.handleCallback(Handler.java:605)
1D018:  11-24 22:33:10.179  4850  4850 W System.err:    at
android.os.Handler.dispatchMessage(Handler.java:92)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
android.os.Looper.loop(Looper.java:137)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
android.app.ActivityThread.main(ActivityThread.java:4424)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
java.lang.reflect.Method.invokeNative(Native Method)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
java.lang.reflect.Method.invoke(Method.java:511)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
dalvik.system.NativeStart.main(Native Method)
1D018:  11-24 22:33:10.187  4850  4850 W System.err: Caused by:
java.lang.ClassNotFoundException:
org.chromium.ui.gl.SurfaceTexturePlatformWrapper
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:61)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
java.lang.ClassLoader.loadClass(ClassLoader.java:501)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    at
java.lang.ClassLoader.loadClass(ClassLoader.java:461)
1D018:  11-24 22:33:10.187  4850  4850 W System.err:    ... 13 more
1D018:  11-24 22:33:10.195  4850  4850 F chromium:
[FATAL:jni_android.cc(116)] Check failed: !ClearException(env) &amp;&amp;
clazz. Failed to find class org/chromium/ui/gl/SurfaceTexturePlatformWrapper
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #00 0x5b47262d
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x001f762d
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #01 0x5b463329
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x001e8329
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #02 0x5b5cbc13
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x00350c13
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #03 0x5b463cb7
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x001e8cb7
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #04 0x5b34a053
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x000cf053
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #05 0x5b48e569
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x00213569
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #06 0x5b349ee3
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x000ceee3
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #07 0x5b48cce5
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x00211ce5
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #08 0x5b349fe1
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x000cefe1
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #09 0x5b49b899
/data/data/org.chromium.native_test/lib/libmedia_unittests.so+0x00220899
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #10 0x407ffc33
/system/lib/libdvm.so+0x0001ec33
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #11 0x40839eed
/system/lib/libdvm.so+0x00058eed
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #12 0x40811a8f
/system/lib/libdvm.so+0x00030a8f
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #13 0x40815273
/system/lib/libdvm.so+0x00034273
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #14 0x4084d62f
/system/lib/libdvm.so+0x0006c62f
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #15 0x40854bd9
/system/lib/libdvm.so+0x00073bd9
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #16 0x40811a8f
/system/lib/libdvm.so+0x00030a8f
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #17 0x40815273
/system/lib/libdvm.so+0x00034273
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #18 0x4084d8ff
/system/lib/libdvm.so+0x0006c8ff
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #19 0x40835eb9
/system/lib/libdvm.so+0x00054eb9
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #20 0x401c5813
/system/lib/libandroid_runtime.so+0x00044813
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #21 0x401c637d
/system/lib/libandroid_runtime.so+0x0004537d
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #22 0x00008f0b
/system/bin/app_process+0x00000f0b
1D018:  11-24 22:33:10.195  4850  4850 F chromium: #23 0x4004254d
/system/lib/libc.so+0x0001654d


In other words, libmedia_unittests.so depends on
ui/gl/gl.gyp:gl_jni_headers, so most likely what they really want is
ui/gl/gl.gyp:gl


https://codereview.chromium.org/83243007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Ami GONE FROM CHROMIUM

On 2013/11/29 22:41:18, tfarina wrote: > Ami, PTAL. trybot still seems sad

7 years ago (2013-11-29 23:40:03 UTC) #15

tfarina

hating android!! It is also causing me problems in another patch: https://codereview.chromium.org/82353002/

7 years ago (2013-11-29 23:50:46 UTC) #16

tfarina

Ami, I added it back to media_unittests. I have setup android build, I can build ...

7 years ago (2013-12-05 23:01:23 UTC) #17

Ami GONE FROM CHROMIUM

On 2013/12/05 23:01:23, tfarina wrote: > Ami, I added it back to media_unittests. I have ...

7 years ago (2013-12-05 23:16:03 UTC) #18

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/83243007/620001

7 years ago (2013-12-06 04:13:32 UTC) #19

Message was sent while issue was closed.

Change committed as 239184

Expand Messages | Collapse Messages